Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new time role #895

Merged
merged 4 commits into from Apr 10, 2019
Merged

Add new time role #895

merged 4 commits into from Apr 10, 2019

Conversation

melanierichards
Copy link
Contributor

@melanierichards melanierichards commented Jan 31, 2019

Fixes #878

(Moved the questions I had in this PR to the issue itself, for a single-point-of-truth for historic discussion)


Preview | Diff

@melanierichards
Copy link
Contributor Author

melanierichards commented Mar 28, 2019

Just made a minor stylistic adjustment to the definition based on @mcking65's feedback a couple calls ago: "Represents…" becomes "An element that represents…" If a more specific term than "element" is desired, maybe "phrase"? Perhaps pending creation of a new phrase abstract role.

index.html Outdated Show resolved Hide resolved
Copy link
Member

@jnurthen jnurthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the namefrom - I have a feeling that might be causing the weirdness

@jnurthen jnurthen merged commit 4278c8a into w3c:master Apr 10, 2019
joanmarie pushed a commit that referenced this pull request Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants